Tidy cleanup #143724

hkBst · 2025-07-10T08:09:56Z

No description provided.

rustbot · 2025-07-10T08:10:05Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-10T08:10:08Z

There are changes to the tidy tool.

cc @jieyouxu

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

src/tools/tidy/src/features.rs

klensy · 2025-07-10T12:51:54Z

src/tools/tidy/src/gcc_submodule.rs

    //  e607be166673a8de9fc07f6f02c60426e556c5f2 src/gcc (master-e607be166673a8de9fc07f6f02c60426e556c5f2.e607be)
    // +e607be166673a8de9fc07f6f02c60426e556c5f2 src/gcc (master-e607be166673a8de9fc07f6f02c60426e556c5f2.e607be)
    let git_output = String::from_utf8_lossy(&git_output.stdout)
-        .trim()


https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace

bors · 2025-07-10T13:51:02Z

☔ The latest upstream changes (presumably #143721) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-07-11T05:39:35Z

tidy extra checks were modified.

cc @lolbinarycat

Mark-Simulacrum · 2025-07-13T11:31:10Z

@bors r+ rollup

bors · 2025-07-13T11:31:12Z

📌 Commit 8bf88a2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Tidy cleanup

Rollup of 8 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143724 (Tidy cleanup) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143880 (tests: Test line debuginfo for linebreaked function parameters) Failed merges: - #143630 (Drop `./x suggest`) - #143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) r? `@ghost` `@rustbot` modify labels: rollup

Tidy cleanup

Rollup of 16 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143592 (UWP: link ntdll functions using raw-dylib) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143710 (Updates to random number generation APIs) - #143724 (Tidy cleanup) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143893 (Don't require `eh_personality` lang item on targets that have a personality) Failed merges: - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143891 (Port `#[coverage]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

Tidy cleanup

Rollup of 17 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143710 (Updates to random number generation APIs) - #143724 (Tidy cleanup) - #143738 (Move several float tests to floats/mod.rs) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143893 (Don't require `eh_personality` lang item on targets that have a personality) - #143901 (Region constraint nits) Failed merges: - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143891 (Port `#[coverage]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143724 (Tidy cleanup) - #143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143917 (Change "allocated object" to "allocation".) - #143918 (Tier check cleanup) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143724 - hkBst:tidy-cleanup, r=Mark-Simulacrum Tidy cleanup

tshepang · 2025-07-15T05:18:10Z

src/tools/tidy/src/ui_tests.rs

        let blessed_issues_path = tidy_src.join("issues_blessed.txt");
        let mut blessed_issues_txt = fs::File::create(&blessed_issues_path).unwrap();
-        blessed_issues_txt.write(issues_txt_header.as_bytes()).unwrap();
+        blessed_issues_txt.write_all(issues_txt_header.as_bytes()).unwrap();


I wonder if write has caused problems in the past

Rollup of 10 pull requests Successful merges: - rust-lang/rust#143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - rust-lang/rust#143681 (bootstrap/miri: avoid rebuilds for test builds) - rust-lang/rust#143724 (Tidy cleanup) - rust-lang/rust#143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) - rust-lang/rust#143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - rust-lang/rust#143875 (update issue number for `const_trait_impl`) - rust-lang/rust#143881 (Use zero for initialized Once state) - rust-lang/rust#143887 (Run bootstrap tests sooner in the `x test` pipeline) - rust-lang/rust#143917 (Change "allocated object" to "allocation".) - rust-lang/rust#143918 (Tier check cleanup) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jul 10, 2025

rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 10, 2025

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the tidy-cleanup branch from 542dd67 to 97473a1 Compare July 10, 2025 08:29

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the tidy-cleanup branch from 97473a1 to c4b228c Compare July 10, 2025 12:24

klensy reviewed Jul 10, 2025

View reviewed changes

src/tools/tidy/src/features.rs Show resolved Hide resolved

klensy reviewed Jul 10, 2025

View reviewed changes

rust-cloud-vms bot force-pushed the tidy-cleanup branch 2 times, most recently from 9eccfdd to 11c005e Compare July 10, 2025 14:24

hkBst added 5 commits July 11, 2025 05:39

tidy: clippy fixes

ef5c209

tidy: simplify fluent file extension checking

a4e994e

tidy: move to edition 2024

9bd4c90

tidy: use flatten instead of manual flatten

6356faf

tidy: use write_all

8bf88a2

rust-cloud-vms bot force-pushed the tidy-cleanup branch from 11c005e to 8bf88a2 Compare July 11, 2025 05:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 13, 2025

Rollup merge of rust-lang#143724 - hkBst:tidy-cleanup, r=Mark-Simulacrum

6137cbb

Tidy cleanup

matthiaskrgr mentioned this pull request Jul 13, 2025

Rollup of 8 pull requests #143899

Closed

fmease added a commit to fmease/rust that referenced this pull request Jul 14, 2025

Rollup merge of rust-lang#143724 - hkBst:tidy-cleanup, r=Mark-Simulacrum

9f51162

Tidy cleanup

fmease mentioned this pull request Jul 14, 2025

Rollup of 16 pull requests #143912

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 14, 2025

Rollup merge of rust-lang#143724 - hkBst:tidy-cleanup, r=Mark-Simulacrum

1969d41

Tidy cleanup

jhpratt mentioned this pull request Jul 14, 2025

Rollup of 17 pull requests #143916

Closed

Kobzol mentioned this pull request Jul 14, 2025

Rollup of 10 pull requests #143919

Merged

bors merged commit 0d4d85b into rust-lang:master Jul 14, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 14, 2025

rust-timer added a commit that referenced this pull request Jul 14, 2025

Unrolled build for #143724

d01b200

Rollup merge of #143724 - hkBst:tidy-cleanup, r=Mark-Simulacrum Tidy cleanup

tshepang reviewed Jul 15, 2025

View reviewed changes

hkBst deleted the tidy-cleanup branch July 15, 2025 05:41

mu001999 mentioned this pull request Sep 30, 2025

Add new optional tidy check to check if ftl error messages are unused #147191

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tidy cleanup #143724

Tidy cleanup #143724

Uh oh!

hkBst commented Jul 10, 2025

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

klensy Jul 10, 2025

Uh oh!

hkBst Jul 10, 2025

Uh oh!

bors commented Jul 10, 2025

Uh oh!

rustbot commented Jul 11, 2025

Uh oh!

Mark-Simulacrum commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

Uh oh!

tshepang Jul 15, 2025

Uh oh!

Uh oh!

Tidy cleanup #143724

Tidy cleanup #143724

Uh oh!

Conversation

hkBst commented Jul 10, 2025

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

klensy Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

hkBst Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 10, 2025

Uh oh!

rustbot commented Jul 11, 2025

Uh oh!

Mark-Simulacrum commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

Uh oh!

tshepang Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!